Skip to content

Change of copyright year from 2017 to 2018. #13027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Change of copyright year from 2017 to 2018. #13027

merged 3 commits into from
Jan 7, 2018

Conversation

bhargavmehta
Copy link
Member

@bhargavmehta bhargavmehta commented Jan 7, 2018

Description

Have changed files for copyright.
#MM18IN

Manual testing scenarios

home page

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 7, 2018

CLA assistant check
All committers have signed the CLA.

@dmanners dmanners added the mm18in label Jan 7, 2018
@@ -1,5 +1,5 @@
/**
* Copyright © 2013-2017 Magento, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.

@@ -1,5 +1,5 @@
/**
* Copyright © 2013-2017 Magento, Inc. All rights reserved.
* Copyright © 2013-2018 Magento, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.

@@ -1,5 +1,5 @@
/**
* Copyright © 2013-2017 Magento, Inc. All rights reserved.
* Copyright © 2013-2018 Magento, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.

@magento-team magento-team merged commit 908a143 into magento:2.2-develop Jan 7, 2018
@DanielRuf
Copy link
Contributor

This is not very dynamic or flexible in my opinion.

I would either recommend the JS solution or the direct way with PHP. See http://updateyourfooter.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants