Default Welcome message is broken on storefront with enabled translate-inline

[pareshpansuriya]

Description
Earlier escapeHtmlAttr() is used instead of escapeHtml(). As it is simple message so we have replaced this method: escapeHtmlAttr() with escapeHtml().

1. Default Welcome message is broken on storefront with enabled translate-inline #12711: Default Welcome message is broken on storefront with enabled translate-inline

[magento-cicd2]

All committers have signed the CLA.

[ishakhsuvarov]

Hi @paresh1
Please sign the CLA so that we can proceed with the review and merge

[mzeis]

Hi @pareshpansuriya,

thanks for your contribution! Tests showed that his PR fixes the problem for the blank theme but not for the Luma theme on the current commit e411c1d in branch 2.2-develop.

Please can you have a look at this? Thanks!

Before:

After:

[mzeis]

@pareshpansuriya To be precise: you actually did the right thing and fixed the "Default welcome msg"! 👍 If you don't want to fix the second problem shown in the screenshots please tell.

[pareshpansuriya]

I have try to solve that problem that create another problem when try to translate text "or" , that display individual whole text in popup for text : [{'shown':'or','translated':'or','original':'or','location':'Tag attribute (ALT, TITLE, etc.)'}]

Please check screen-shot.

So I am trying for solve that issue. Any help from you is appreciate.

[mzeis]

@pareshpansuriya Thanks for taking a look at this! I'm sorry but I'm not able to have a look at the "or" issue in the next days.

I suggest we get your fix for the original issue merged so your contribution can make it into a release soon. For the problem with "or", a separate issue could be created and then worked on. Is this ok for you?

[pareshpansuriya]

Ok no problem I create pull request for that.

[pareshpansuriya]

Thanks for do that, I actualy dont know how to edit PR for commit can you give any reference.

[mzeis]

When you make a new commit to your branch and execute git push again, the PR is updated!

The problem from #13038 (comment) is still there with this commit 7e913f1, right?

[pareshpansuriya]

Yes that is new problem with that commit, that commit have solved the previous issue #12711

[mzeis]

@pareshpansuriya Ok. We will merge the "Welcome message" fix without a fix for the "or" problem. Thanks for your patience!

[mzeis]

@pareshpansuriya Thanks again for your patience and your contribution! Your PR has been merged into 2.2-develop.