Feature minimum order amount notice issue #13039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakhsuvarov
requested changes
Jan 7, 2018
| */ | ||
| public function __construct( | ||
| \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, | ||
| \Magento\Store\Model\StoreManagerInterface $storeManager, | ||
| \Magento\Framework\Locale\CurrencyInterface $currency | ||
| \Magento\Framework\Locale\CurrencyInterface $currency, | ||
| \Magento\Framework\Pricing\Helper\Data $priceHelper |
There was a problem hiding this comment.
This argument should be optional to maintain backward compatibility
More info available in devdocs
…m:neeta-wagento/magento2 into feature-minimum-order-amount-notice-issue
ishakhsuvarov
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During currency switch notice message shows wrong calculation of minimum order amount.
Description
This is about notice message of min order amount on cart page.When we have set min order amount and on cart page someone change currency, user see same amount and only currency symbol changed. It should recalculate amount also.
Instead of currency convert, we use price helper then it gives us re calculated price amount in notice message.
Fixed Issues (if relevant)
Manual testing scenarios
Preconditions
Any Product must be created and enabled in frontend with the price greater then 0 or less then 1000
Steps to reproduce
Enable Minimum Order Amount
Login to [Magento Admin Panel]/ Stores -> Configuration -> Sales -> Sales -> Minimum Order Amount and do the following
Set Enable "Yes"
Enter Amount for example 1000
Leave Description Message text blank
Leave Error to Show in Shopping Cart blank
Save the Configurations by clicking on "Save Config" button on top right corner
Now setup Multiple currencies for that follow below steps
Go to section Stores -> Configuration->General->Currency Setup
Now select multiple currencies from Allowed Currencies by pressing ctrl key
select Brazilian Real, Indian Rupee, Japanese Yen, Russian Ruble, US Dollar
Import Currency Rates
Go to Stores -> Under Currency Title click on Currency Rates.
Select any of service and click on import rates it will import live currency rates.
Go to Frontend Add any product in shopping cart add any product 1 qty which has price less then 1000.
Go to cart page "View and Edit Cart" link which you can see on Minicart Popup or by browsing url [Magento base url]/heckout/cart/
You can see the default message on "Minimum order amount is $1,000.00"
Now change the currencies from header upper right corner. You can see Minimum order amount is $1,000.00 in any currency you selected
Expected Result
Contribution checklist