Skip to content

Fix for #11796 Magento2.2.0 home page product grid issues #13081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2018

Conversation

punitv
Copy link

@punitv punitv commented Jan 10, 2018

Description

Fixed homepage product grid issues.

  • Display 5 products in a row and with no margin addition for the first product on next row (Desktop view).
  • Display 2 products in a row (Mobile portrait mode).
  • Display 3 products in a row (Mobile landscape mode).

Fixed Issues (if relevant)

  1. Magento2.2.0 home page product grid issues #11796: Magento2.2.0 home page product grid issues

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 10, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 10, 2018
@punitv
Copy link
Author

punitv commented Jan 10, 2018

I tried many times signing Contributor License Agreement but still shows not signed yet.

@dmanners
Copy link
Contributor

@punitv I think your user that committed is different from the user that you are signed into github with. Please either update the committed user or change the github user.

@punitv
Copy link
Author

punitv commented Jan 10, 2018

@dmanners Yes, I fork repository with one user-email and committed code using different user-email. Will this be the way to update the committed user.

@dmanners
Copy link
Contributor

@punitv you will need to change all your commits. I think https://stackoverflow.com/a/3042512 should cover your needs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants