11828 Fix issue with swatch colour block not showing in admin panel o…

[chris-pook]

…nce colour selected (PHP7.1.x issue).

Description

Using PHP7.1.x the swatch colour block preview in the admin panel attribute will not show the actual colour as the inline style is set to style"b". This is due to PHP no longer allowing strings to be manipulated as arrays.

Fixed Issues (if relevant)

1. Visual Swatches not showing swatch color in admin #11828: Visual Swatches not showing swatch color in admin

Manual testing scenarios

Preconditions
Magento CE 2.2
PHP 7.1.0
Steps to reproduce
Inside admin, go to Stores->Product and click on an attribute that contains visual swatches.
Expected result
Visual Swatches that have a color assigned should show that color in the swatch box.
Actual result
Although the color swatch values are being saved, the visual representation of the color in the box is colorless.

Contribution checklist

• [ x] Pull request has a meaningful description of its purpose
• [ x] All commits are accompanied by meaningful commit messages
• [ x] All new or changed code is covered with unit/integration tests (if applicable)
• [ x] All automated tests passed successfully (all builds on Travis CI are green)

[orlangur]

Hi @chris-pook, changes looks good to me, however for any fix we should process PR into 2.2-develop branch first.

Could you please create such PR consisting of a single commit? Also would be nice to fix type for $swatchStoreValue function parameter.

[chris-pook]

Hi @orlangur , I've added a PR to 2.2-develop here: #13101

Thanks

[okorshenko]

PR to 2.2 #13101 has been merged

[orlangur]

This was ported to 2.3-develop in 1fdee00#diff-9de953a0c8b93c8e681c7e8bcf5cfb6b already. Thanks @chris-pook!