Optimization: magento/module-catalog is_null change to strict comparison#13171
Merged
magento-team merged 3 commits intoJan 16, 2018
Merged
Optimization: magento/module-catalog is_null change to strict comparison#13171magento-team merged 3 commits into
magento-team merged 3 commits into
Conversation
ihor-sviziev
suggested changes
Jan 14, 2018
| { | ||
| $params = ['_current' => true, 'id' => null, 'store' => null]; | ||
| if (is_null($expanded) && $this->_backendSession->getIsTreeWasExpanded() || $expanded == true) { | ||
| if (($expanded === null) && $this->_backendSession->getIsTreeWasExpanded() || $expanded == true) { |
Contributor
There was a problem hiding this comment.
Would be better to remove brackets near $expanded === null. They're not needed there
| $option->getStoreTitle() === null | ||
| ); | ||
| $value['scopeTitleDisabled'] = is_null($option->getStoreTitle()) ? 'disabled' : null; | ||
| $value['scopeTitleDisabled'] = ($option->getStoreTitle() === null) ? 'disabled' : null; |
| $option->getStorePrice() === null | ||
| ); | ||
| $value['scopePriceDisabled'] = is_null($option->getStorePrice()) ? 'disabled' : null; | ||
| $value['scopePriceDisabled'] = ($option->getStorePrice() === null) ? 'disabled' : null; |
| { | ||
| $this->_renderFilters(); | ||
| $countSelect = is_null($select) ? $this->_getClearSelect() : $this->_buildClearSelect($select); | ||
| $countSelect = ($select === null) ? $this->_getClearSelect() : $this->_buildClearSelect($select); |
Contributor
Author
|
@ihor-sviziev thank you for your review! I made requested changes according to your review. Please, check. :) |
ihor-sviziev
suggested changes
Jan 14, 2018
| $this->_productLimitationFilters->setUsePriceIndex(true); | ||
|
|
||
| if (!isset($this->_productLimitationFilters['customer_group_id']) && is_null($customerGroupId)) { | ||
| if (!isset($this->_productLimitationFilters['customer_group_id']) && ($customerGroupId === null)) { |
Contributor
There was a problem hiding this comment.
Please remove unnecessary brackets.
| $customerGroupId = $this->_customerSession->getCustomerGroupId(); | ||
| } | ||
| if (!isset($this->_productLimitationFilters['website_id']) && is_null($websiteId)) { | ||
| if (!isset($this->_productLimitationFilters['website_id']) && ($websiteId === null)) { |
Contributor
|
@coderimus few more issues are left. Sorry for not sending it at first time |
Contributor
Author
|
@ihor-sviziev thank you for your comments and detail review! I added needed changes, please, check. |
ihor-sviziev
approved these changes
Jan 14, 2018
magento-team
pushed a commit
that referenced
this pull request
Jan 16, 2018
… strict comparison #13171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is the one of the optimization PR linked with the
is_null()change. I decided to do them per module just to avoid any mistake during delivery and review.Best regards,
Alex
Description
Micro-optimizations for Magento\Catalog
Magento2 has next sniff MicroOptimizations It checks next:
is_null must be avoided. Use strict comparison instead.Some classes are under
// @codingStandardsIgnoreFilesuch as Magento\Catalog module models, block and cannot be checked during static tests. In this PR I replacedis_nullwith strict comparison only for models and block in Magento\Catalog module.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist