Skip to content

Fix a misspelled parameter name in TaxTest #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jan 18, 2018
Merged

Fix a misspelled parameter name in TaxTest #13189

merged 32 commits into from
Jan 18, 2018

Conversation

akiojalehto
Copy link
Member

@akiojalehto akiojalehto commented Jan 15, 2018

Description

Found a misspelled parameter name in \Magento\Weee\Test\Unit\Model\TaxTest::testGetWeeeAmountExclTax

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@akiojalehto akiojalehto changed the title Fix a misspelled parameter name Fix a misspelled parameter name in TaxTest Jan 15, 2018
@ihor-sviziev
Copy link
Contributor

@akiojalehto could you prepare 1 pull request instead of 16 with all your changes? It will decrease overhead for processing each separate PR by magento team.

@akiojalehto
Copy link
Member Author

Sorry I didn't mean to commit so much, but kept finding more of these.. And then I thought that these are in separated contexts that it might make sense to keep these separated.

Don't have anymore for now, if you can process these it might be easier. I will collect these kind of commits in the future for a single PR if I find more.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jan 16, 2018

@akiojalehto your pull requests actually have 1 context: fixing misspellings in the core. Currently is will not be easy to process 16 PRs, please merge all your changes into 1 PR and it will be processed.

Thank you!

PS: Here is example of PR that had big list of changes that was successfully processed without any issues: #11235

@okorshenko
Copy link
Contributor

Hi @akiojalehto
Please let us know if you can merge all misspellings Prs into one

@akiojalehto
Copy link
Member Author

Sure, I'll try to get it done today

@okorshenko okorshenko self-assigned this Jan 17, 2018
@okorshenko
Copy link
Contributor

I'm working on this right now

@okorshenko
Copy link
Contributor

All done. Working on PR review and testing

@akiojalehto
Copy link
Member Author

Nice job, thanks! Sorry for the trouble.

@okorshenko
Copy link
Contributor

No problem. Thank you for code cleanup!

@magento-team magento-team merged commit 1b569cb into magento:2.3-develop Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants