-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix a misspelled parameter name in TaxTest #13189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a misspelled parameter name in TaxTest #13189
Conversation
@akiojalehto could you prepare 1 pull request instead of 16 with all your changes? It will decrease overhead for processing each separate PR by magento team. |
Sorry I didn't mean to commit so much, but kept finding more of these.. And then I thought that these are in separated contexts that it might make sense to keep these separated. Don't have anymore for now, if you can process these it might be easier. I will collect these kind of commits in the future for a single PR if I find more. |
@akiojalehto your pull requests actually have 1 context: fixing misspellings in the core. Currently is will not be easy to process 16 PRs, please merge all your changes into 1 PR and it will be processed. Thank you! PS: Here is example of PR that had big list of changes that was successfully processed without any issues: #11235 |
Hi @akiojalehto |
Sure, I'll try to get it done today |
I'm working on this right now |
All done. Working on PR review and testing |
Nice job, thanks! Sorry for the trouble. |
No problem. Thank you for code cleanup! |
Description
Found a misspelled parameter name in \Magento\Weee\Test\Unit\Model\TaxTest::testGetWeeeAmountExclTax
Contribution checklist