Default Welcome message is broken on storefront with enabled translate-inline#13463
Closed
pareshpansuriya wants to merge 2 commits intomagento:2.2-developfrom
Closed
Default Welcome message is broken on storefront with enabled translate-inline#13463pareshpansuriya wants to merge 2 commits intomagento:2.2-developfrom
pareshpansuriya wants to merge 2 commits intomagento:2.2-developfrom
Conversation
Contributor
|
Hi @pareshpansuriya, thank you for your new PR! Is it correct that this PR fixes the problem with "or" mentioned in #13038 (comment)? If yes, then please apply the push https://github.com/magento/magento2/pull/13463/files#diff-41a6926737ae8f1d10201d49df2ef5ddR16 to the old PR #13038 and I close this one as a duplicate. Sorry if I confused you wit my message in #13038. |
pareshpansuriya
commented
Feb 9, 2018
Contributor
Author
pareshpansuriya
left a comment
pareshpansuriya
left a comment
There was a problem hiding this comment.
As duplicate
Contributor
Author
|
Can you check I have done in right way. or let me know how to do. |
Contributor
|
Hi @pareshpansuriya, thank you for your reply! Please push your fix |
Contributor
Author
|
How to do that ? I not understand that. |
Contributor
|
Don't worry, I will do it! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Earlier escapeHtmlAttr() is used instead of escapeHtml(). As it is simple message so we have replaced this method: escapeHtmlAttr() with escapeHtml().
Fixed Issues (if relevant)