Skip to content

Stop cast of item_qty to int #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Feb 6, 2018

Description

Casting the item_qty param as an int prevented qty increments from
being allowed when updating the qty via the minicart.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

  1. Create product with "Qty Uses Decimal" set to "Yes"
  2. Add product to cart with qty of 1.
  3. Using the minicart, change the item qty to 1.5 and click update.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Feb 6, 2018
Casting the `item_qty` param as an `int` prevented qty increments from
being allowed when updating the qty via the minicart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants