Fixed fatal error on "magento sampledata:deploy" when magento is not installed. #13571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okorshenko
previously approved these changes
Feb 8, 2018
okorshenko
suggested changes
Feb 8, 2018
| * @SuppressWarnings(PHPMD.UnusedFormalParameter) | ||
| */ | ||
| public function __construct( | ||
| ComposerInformation $composerInformation, | ||
| Filesystem $filesystem, | ||
| PackageFactory $packageFactory, | ||
| ComponentRegistrarInterface $componentRegistrar, | ||
| \Magento\Framework\Filesystem\Directory\ReadInterfaceFactory $directoryReadFactory = null | ||
| \Magento\Framework\Filesystem\Directory\ReadFactory $directoryReadFactory = null |
There was a problem hiding this comment.
it would great to cover this with the tests
okorshenko
approved these changes
Feb 8, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 15, 2018
…magento is not installed. #13571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed fatal error on "magento sampledata:deploy" when magento is not installed.
Original PR #8990
Manual testing scenarios
Manual testing scenarios
Additional test cases see #8990
Contribution checklist