Skip to content

[Forwardport] magento/magento2#11485 do the stock check on default level because the stock on website level isn't updated and should be ignored #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Feb 13, 2018

Original Pull Request

#11485 (created by @joost-florijn-kega)

Included Commits

  1. b58bc13
  2. 5206728

General

Product's are linked to categories without notice of any website. The visual merchandiser shows to lowest price of in stock and active simples that are associated with the configurable. The stock check ignores the website scope so if a simple is in stock on the website level but out of stock on default level it should been ignored to determine the lowest price. This commit fixes that issue.

Fixed Issues (if relevant)

  1. Visual Merchandiser show prices of out of stock simple products for the associated configurable product. #11484: Visual Merchandiser show prices of out of stock simple products for the associated configurable product

Manual testing scenarios

  1. Have a configurable product that is associated with a simple product which is out of stock on default website level (id: 0) and is in stock on website level.
  2. Go to the visual merchandiser of the category where the configurable product is linked.
  3. Look up the configurable product in the visual merchandiser Tile overview.

Before the fix:

  • The price of the out of stock simple product was shown.

After the fix:

  • The price '0,00' is shown.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…evel because the stock on website level isn't updated and should be ignored
@nmalevanec nmalevanec changed the title [Forwardport] magento/magento2#:11485 do the stock check on default level because the stock on website level isn't updated and should be ignored [Forwardport] magento/magento2#11485 do the stock check on default level because the stock on website level isn't updated and should be ignored Feb 13, 2018
@okorshenko okorshenko self-assigned this Feb 13, 2018
@okorshenko okorshenko added this to the February 2018 milestone Feb 13, 2018
@magento-engcom-team magento-engcom-team merged commit 4a46800 into magento:2.3-develop Feb 15, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 15, 2018
…el because the stock on website level isn't updated and should be ignored #13632
@nmalevanec nmalevanec deleted the forwardport-pull-11485 branch August 21, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants