Update Store getConfig() to respect valid false return value #13653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using a config setting Yes/No will return string '0' when No is saved. Method will therefore fetch default config value because '0' equals false. Removed the
ScopeConfigInterface::SCOPE_TYPE_DEFAULT
because it's the default value.Fixed Issues (if relevant)
Manual testing scenarios
No
.'0'
is returned and value from default scope is fetched.Contribution checklist