Skip to content

[Port 2.3-develop] Show redirect_to_base config in store scope #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

JeroenVanLeusden
Copy link
Member

Description

Add web/unsecure/base_url config to website and store scope. Setting is used that way in the code, see:
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php#L80-L83
https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Store/Model/BaseUrlChecker.php#L50-L53

The tests also use store scope.

Fixed Issues (if relevant)

  1. None I could find.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@JeroenVanLeusden JeroenVanLeusden changed the title Show redirect_to_base config in store scope [Port 2.3-develop] Show redirect_to_base config in store scope Feb 14, 2018
@JeroenVanLeusden
Copy link
Member Author

@dmanners Backport of #13614, can you process this also?

@dmanners dmanners self-assigned this Feb 15, 2018
@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 15, 2018
@magento-engcom-team magento-engcom-team merged commit e68e175 into magento:2.3-develop Feb 15, 2018
@JeroenVanLeusden JeroenVanLeusden deleted the patch-12 branch March 20, 2018 10:45
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants