-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #13315. Mobile 'Payments methods' step looks bad on mobile #13777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 1 commit into
magento:2.2-develop
from
Frodigo:fix/mobile-payment-methods-step-looks-bad-on-mobile
Feb 27, 2018
Merged
Fix #13315. Mobile 'Payments methods' step looks bad on mobile #13777
magento-engcom-team
merged 1 commit into
magento:2.2-develop
from
Frodigo:fix/mobile-payment-methods-step-looks-bad-on-mobile
Feb 27, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faa3cdd
to
db7d299
Compare
ihor-sviziev
approved these changes
Feb 22, 2018
Hi @ihor-sviziev, thank you for the review. |
@magento-engcom-team Thank you. I accepted the invitation. |
@Frodigo could you prepare forwardport PR to 2.3-develop branch with the same changes? |
@ihor-sviziev yes, also I will prepare backport to 2.1-develop branch. |
Thank you!
…On Feb 28, 2018 10:12, "Marcin Kwiatkowski" ***@***.***> wrote:
@ihor-sviziev <https://github.com/ihor-sviziev> yes, also I will prepare
backport to 2.1-develop branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13777 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AByXUZ4PY8u5YI9OI3-IX1T84H4hjMDNks5tZQpggaJpZM4SOa25>
.
|
This was referenced Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for bad looks of step-title in the payment methods section at the checkout.
I added padding to the .step-title element such as padding in the other elements in this section. I used
@checkout-payment-method-title-mobile__padding
variable.I apply my changes to both Magento themes (blank & luma)
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist