Skip to content

Fix #13315. Mobile 'Payments methods' step looks bad on mobile #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Frodigo
Copy link
Contributor

@Frodigo Frodigo commented Feb 21, 2018

Description

Fixes for bad looks of step-title in the payment methods section at the checkout.

I added padding to the .step-title element such as padding in the other elements in this section. I used @checkout-payment-method-title-mobile__padding variable.

I apply my changes to both Magento themes (blank & luma)

Fixed Issues (if relevant)

  1. Mobile "Payment Methods" step looks bad on mobile #13315: I "Payment Methods" step looks bad on mobile

Manual testing scenarios

  1. Go to frontend, add some product to shopping cart on mobile (or in iphone emulation mode on chrome)
  2. Go to Checkout, fill "shipping" step, click "Next" button
  3. See "Payment Methods" block
  4. Step title heading "Payment Method" should be correctly aligned with other elements in this section

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 21, 2018

CLA assistant check
All committers have signed the CLA.

@Frodigo Frodigo force-pushed the fix/mobile-payment-methods-step-looks-bad-on-mobile branch from faa3cdd to db7d299 Compare February 21, 2018 22:17
@ihor-sviziev ihor-sviziev self-assigned this Feb 22, 2018
@ihor-sviziev ihor-sviziev self-requested a review February 22, 2018 09:52
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-88235 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Frodigo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@Frodigo
Copy link
Contributor Author

Frodigo commented Feb 22, 2018

@magento-engcom-team Thank you. I accepted the invitation.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 28, 2018

@Frodigo could you prepare forwardport PR to 2.3-develop branch with the same changes?

@Frodigo
Copy link
Contributor Author

Frodigo commented Feb 28, 2018

@ihor-sviziev yes, also I will prepare backport to 2.1-develop branch.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants