Send order email for Braintree Paypal orders #13898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidolov
requested changes
Mar 1, 2018
pmclain
force-pushed
the
frontend/order-emails
branch
from
cdc2bbe to
c751c86
Compare
|
@sidolov Moved the observer out of the Webapi namespace and updated the event configs. |
sidolov
requested changes
Mar 1, 2018
Order emails are sent using observers on the `sales_model_service_quote_submit_success` event, but only in the `webapi_rest` and `webapi_soap` areas. When customers checkout with Braintree Paypal the order placement occurs in the `frontend` area with a request to `Magento\Braintree\Controller\Paypal\PlaceOrder`, so these orders were not sent a new order email. Fixes magento#13778 Fixes magento#12792
pmclain
force-pushed
the
frontend/order-emails
branch
from
c751c86 to
975137b
Compare
|
@sidolov Wow that was sloppy. I've punished myself accordingly 😄 |
sidolov
approved these changes
Mar 1, 2018
|
Hi @sidolov, thank you for the review. |
ghost
approved these changes
Mar 3, 2018
| <iframe src="https://www.facebook.com/plugins/follow?href=https%3A%2F%2Fwww.facebook.com%2Fprofile.php%3Fid%3D100023737004476&layout=standard&show_faces=true&colorscheme=light&width=450&height=80" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:450px; height:80px;" allowTransparency="true"></iframe> |
This was referenced Mar 7, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 7, 2018
dimonovp
pushed a commit
to dimonovp/magento2
that referenced
this pull request
Mar 20, 2018
This was referenced Mar 20, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commits adds a frontend observer for sending new order emails.
Order emails are sent using observers on the
sales_model_service_quote_submit_successevent, but only in thewebapi_restandwebapi_soapareas. When customers checkout withBraintree Paypal the order placement occurs in the
frontendarea witha request to
Magento\Braintree\Controller\Paypal\PlaceOrder, so theseorders were not sent a new order email.
Fixed Issues (if relevant)
Manual testing scenarios
braintree/paypal/reviewbraintree/paypal/placeorderContribution checklist