Skip to content

#13899 Solve Canada Zip Code pattern #13930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tadeobarranco
Copy link
Contributor

@tadeobarranco tadeobarranco commented Mar 2, 2018

Add new pattern to validate Canada Zip Codes

Description

Change pattern validation for Canada Zip Codes

Fixed Issues (if relevant)

  1. Postal code (zip code) for Canada should allow postal codes without space #13899: Postal code (zip code) for Canada should allow postal codes without space

Manual testing scenarios

  1. Add Product to Cart
  2. Go to shopping cart
  3. Select Canda Country
  4. Put ZipCode: A1B2C3

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 2, 2018

CLA assistant check
All committers have signed the CLA.

@tadeobarranco tadeobarranco self-assigned this Mar 2, 2018
@sidolov
Copy link
Contributor

sidolov commented Mar 3, 2018

Hi @tadeobarranco , according to canadapost.ca guide, postal code must be with one space between the first three and the last three characters, otherwise, it will be invalid.
Do you have any additional information?
Thanks

@tadeobarranco
Copy link
Contributor Author

Hi @sidolov, totally agree with you, but in the issue linked to this PR, there is this specific text "This should also allow postal code without space A1B2C3", so that is why this is allowed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants