Skip to content

fix #13530 #13931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix #13530 #13931

wants to merge 1 commit into from

Conversation

AngelBS
Copy link

@AngelBS AngelBS commented Mar 2, 2018

Description

Fixed Issues (if relevant)

  1. "Template file 'header.html' is not found" error while trying to save Design Configuration. #13530: "Template file 'header.html' is not found" error while trying to save Design Configuration.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 2, 2018

CLA assistant check
All committers have signed the CLA.

@rogyar rogyar self-assigned this Mar 5, 2018
@rogyar
Copy link
Contributor

rogyar commented Mar 8, 2018

Hello, @AngelBS. Thank you for the contribution.
Your solution fixes the behaviour. However, it does not fix the issue.
The design_email_header_template and design_email_footer_template are declared in the frontend area but on the attempt to save the design configuration the system tries to find the mentioned templates in the adminhtml area. That's the main reason for the issue.
So, the templates area upon the request should be fixed first of all (from adminhtml to frontend). After that, we will not have the necessity to duplicate the existing templates in frontend and adminhtml (it does not make sense).
Thanks.

@rogyar
Copy link
Contributor

rogyar commented Mar 15, 2018

@AngelBS are you going to proceed with this PR?

@rogyar
Copy link
Contributor

rogyar commented Apr 1, 2018

Closing this request because of no activity

@rogyar rogyar closed this Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants