Skip to content

Issues 13769. Fix wrong info about sent email in order sender. #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pawcioma
Copy link
Contributor

Prepare pull request for 2.3-develop based on the task: #13878

Description

Fixes wrong info about sent email in Order Sender. Order sender when send method got exception then checkAndSend should return false.

Fixed Issues (if relevant)

  1. Order Email Sender #13769: Order Email Sender

Manual testing scenarios

  1. If we want check issue we should have wrong config sendmail in server.
  2. We should place order.
  3. We had wrong configuration in sendmail, so email not sent.
  4. In database in sales_order we should have email_send and send_email as false.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants