-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Correctly convert config integration api resources #14065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly convert config integration api resources #14065
Conversation
@omiroshnichenko can you please tell me how to fix https://app.codacy.com/app/vrann/magento2/pullRequest?prid=1423301? |
@therool You can ignore it. |
Hi @therool , please, sign CLA, otherwise, we can't process your pull request |
Hi @sidolov, thank you for the review. |
Hi @therool. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Correctly return config based integration api resources. Currently it does not append "root api resource" (
Magento_Backend::admin
) which causes the integrations to be reset all the time even when there are no data changes when theMagento\Integration\Setup\Recurring
is run (setup:upgrade
) becauseMagento\Authorization\Model\Acl\AclRetriever::getAllowedResourcesByUser
returns resource tree including "root api resource" (Magento_Backend::admin
) and when they are compared they do not match.Detailed explanation:
Magento_Backend::admin
)Magento_Backend::admin
)Magento_Backend::admin
) and the other not)Fixed Issues (if relevant)
Manual testing scenarios
etc/integration.xml
with "Magento_Catalog::catalog" resource and without "endpoint_url", "identity_link_url"setup:upgrade
so the integration is createdsetup:upgrade
again - the integration should stay as "Authorized" but it is "Reset" due the issue described aboveContribution checklist