Improve Customer GraphQL Model code quality #14158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused import - Use constant instead of numer for USER_TYPE_GUEST - Removed unneeded fully qualified class name
elzekool
force-pushed
the
feature/improve-customer-graphql-model
branch
from
845cfa6 to
bae191e
Compare
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphQL Customer Model used "4" as customer type. This makes is less clear what the intent is. Corrected it to use the relevant USER_TYPE_GUEST from UserContextInterface. Also removed an unused import and unneeded fully qualified class name.
Contribution checklist