Use cartId from REST URL #14161
Closed
Use cartId from REST URL #14161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzekool
force-pushed
the
14086-Use-cartId-in-REST-URL
branch
2 times, most recently
from
8ead162 to
a9d757b
Compare
|
Hello, @elzekool. Thank you for your contribution. |
For /V1/carts/mine/items and /V1/carts/mine/items the quoteId from the quote item is used. For guest cart this is confusing as it makes the cartId in the URL useless. For logged in carts it makes it unsafe as it allows adding products to any active cart. Relates to: magento#14086
elzekool
force-pushed
the
14086-Use-cartId-in-REST-URL
branch
from
a9d757b to
f06ed69
Compare
|
Hello @elzekool. Are you going to proceed working on this PR? |
|
I am closing this PR now due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution for Guest cart API ignoring cartId in url for some methods
Description
For /V1/carts/mine/items and /V1/carts/mine/items the quoteId from the
quote item is used. For guest cart this is confusing as it makes the
cartId in the URL useless. For logged in carts it makes it unsafe as it
allows adding products to any active cart.
Fixed Issues
Contribution checklist