Skip to content

[Forwardport] magento/magento2#13820: IE11 minicart not updating on configurable pr… #14192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

[Forwardport] magento/magento2#13820: IE11 minicart not updating on configurable pr… #14192

merged 1 commit into from
Mar 21, 2018

Conversation

namlier
Copy link
Contributor

@namlier namlier commented Mar 20, 2018

Original Pull Request

#14105
…oduct page (ES6)

Description

In setProductOptions function in app/code/Magento/ConfigurableProduct/view/frontend/web/js/options-updater.js i used underscore.find method instead of ES6 array.find.

Fixed Issues (if relevant)

  1. IE11 minicart not updating on configurable product page (ES6) #13820: IE11 minicart not updating on configurable product page (ES6)

Manual testing scenarios

  1. Open Internet Explorer 11 and go to configurable product page
  2. Select swatch attribute values
  3. Add product to cart
  4. product should be added and mini cart should be updated

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Frodigo
#13820: IE11 minicart not updating on configurable product page (ES6)…
6d4065a 
… - replace array.find to underscore.find in options-updater.js
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 20, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 21, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 6d4065a into magento:2.3-develop Mar 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 21, 2018
ENGCOM-978: [Forwardport] #13820: IE11 minicart not updating on confi…
f7c867c 
…gurable pr… #14192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@namlier @sidolov @magento-engcom-team @Frodigo