Skip to content

[Forwardport] Allow changing head and body element through xml layout updates #14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

[Forwardport] Allow changing head and body element through xml layout updates #14205

merged 1 commit into from
Mar 21, 2018

Conversation

dimonovp
Copy link
Contributor

Original Pull Request

#13817

Description

The change allows updating the head and body parts of a page manually through xml layout updates.

One particular thing this changeset allows is:

<head>
  <meta name="robots" content="NOINDEX, NOFOLLOW"/>
</head>

This solution is curtesy of https://magento.stackexchange.com/questions/126646/magento2-how-to-add-different-custom-css-file-on-specific-cms-pages/166322#166322 and #4454 (comment)

Fixed Issues

  1. CMS Page with <head> in layout update xml #4454: CMS Page with in layout update xml

Closes: #4454

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 20, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 21, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 822c6e9 into magento:2.3-develop Mar 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 21, 2018
ENGCOM-983: [Forwardport] Allow changing head and body element throug…
2b394fd 
…h xml layout updates #14205
@keharper keharper mentioned this pull request Jun 12, 2018
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@dimonovp @sidolov @magento-engcom-team @cedricziel