[Forwardport] Added alias to block 'product.info.description' #14213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where https://github.com/chedaroo/magento2/blob/05ac0d1915b4170a50dfa4ceb597fac3d74f1b23/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml#L25 uses alias html attributes. Problem is as there is no **alias** on this block it's falling back to the block **name** instead which contains `.`. This is leading to elements with invalid html attribute values, specifically ID's
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14011
Description
Fixes bug where https://github.com/chedaroo/magento2/blob/05ac0d1915b4170a50dfa4ceb597fac3d74f1b23/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml#L25 uses alias html attributes.
Problem is as there is no alias on this block it's falling back to the block name instead which contains
.This is leading to elements with invalid html attribute values, specifically ID's.
Fixed Issues (if relevant)
Manual testing scenarios
Go to product view page and scroll down to 'product.info.details' block (Bottom tabs)
Inspect in devtools
Element which had id
'tab-label-product.info.description'now has'tab-label-description'Contribution checklist