Skip to content

[Forwardport] Add website- and storeview-code in stores admin grid #14285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Forwardport] Add website- and storeview-code in stores admin grid #14285

wants to merge 3 commits into from

Conversation

namlier
Copy link
Contributor

@namlier namlier commented Mar 23, 2018

Original Pull Request

#14156
This PR adds the webiste- and storeview-code in the stores admin grid like in Magento 1 stores overview.

Description

The PR joins additionally the code field from the store table to the admin grids row and adds the website code as well as the store view code in the respective renderers.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Go to "Stores" > "Settings / All Stores"
  2. Before applying the PR there are only listed Website, Store and StoreView by their names
  3. After applying the PR there are the respective codes shown beneath the Website and StoreView names

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Andreas Schrammel added 3 commits March 23, 2018 09:15
Add website- and storeview-code in stores Admin-Grid.
Add store code in store admin grid.
Make "Code" string translateable. Translation for "Code" is already
contained in i18n/en_US.csv (Line 101).
@mzeis mzeis self-assigned this Mar 23, 2018
@mzeis
Copy link
Contributor

mzeis commented Mar 23, 2018

This is a duplicate of #14157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants