Skip to content

#7816: Customer_account.xml file abused (2.3) #14322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

#7816: Customer_account.xml file abused (2.3) #14322

merged 1 commit into from
Mar 30, 2018

Conversation

mikewhitby
Copy link
Contributor

@mikewhitby mikewhitby commented Mar 24, 2018 •
edited
Loading

Description

The initial problem was that the paypal module was setting the customer dashbaord page to "Billing Agreements", a previous commit of 36cac17 fixed that, however there is a related issue - the customer account dashboard title was being set in the controller which was not good, so I've fixed that too.

Fixed Issues (if relevant)

  1. Customer_account.xml file abused #7816
  2. Remove title “Billing Agreements” #12852

Manual testing scenarios

  1. Log in
  2. Ensure the page title on the dashboard is "My Account"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mikewhitby
magento#7816: Customer_account.xml file abused
caf5b3e 
This is in addiiton to magento#12852 commit 36cac17 - that fix
removed the title from being set in the `customer_account.xml` file but
the fix seemed to do nothing as the title was always being set in the
controller anyway. I've removed from the controller and added to the
correct layout file.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 24, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dmanners dmanners added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018
@mikewhitby mikewhitby self-assigned this Mar 24, 2018
@mikewhitby mikewhitby changed the title magento/magento2#7816: Customer_account.xml file abused #7816: Customer_account.xml file abused Mar 24, 2018
@mikewhitby mikewhitby changed the title #7816: Customer_account.xml file abused #7816: Customer_account.xml file abused (2.3) Mar 24, 2018
@mzeis mzeis self-assigned this Mar 24, 2018
@mzeis
Copy link
Contributor

mzeis commented Mar 28, 2018

@magento-engcom-team give me new test instance

@magento-engcom-team
Copy link
Contributor

Hi @mzeis, here is your new test Magento instance

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mzeis, thank you for the review.
ENGCOM-1146 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Mar 30, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit caf5b3e into magento:2.3-develop Mar 30, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 30, 2018
ENGCOM-1146: #7816: Customer_account.xml file abused (2.3) #14322
3cf7155
@mzeis
Copy link
Contributor

mzeis commented Mar 31, 2018

Hi @mikewhitby, thank you for your PR! it has been merged into 2.3-develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeis mzeis mzeis approved these changes

Assignees

@mzeis mzeis

Labels
Component: Customer Event: distributed-cd Distributed Contribution Day improvement Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@mikewhitby @magento-cicd2 @mzeis @magento-engcom-team @dmanners