MAGETWO-84709 - Respect Magento document root in CLI

[Tomasz-Silpion]

Description

Due to Magento 2 architecture and hardcoded url paths in \Magento\Framework\App\Filesystem\DirectoryList command line interface returns wrong path to media files when document root is mounted in pub folder.

Fixed Issues (if relevant)

1. [2.x.x] Production mode is not detected in CLI => the uri for media and static are not good and contain pub #8868: [2.x.x] Production mode is not detected in CLI => the uri for media and static are not good and contain pub
2. Cron gets wrong base media URL #9111: Cron gets wrong base media URL

Manual testing scenarios

1. Set server document root to pub directory
2. Run console command that returns base media url.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[ihor-sviziev]

Hi @Tomasz-Silpion @engcom-backlog-nazar ,
Looks like this issue was fixed in 2.2-develop and was included into Magento 2.2.6 release: 4a0dc86
Also the same fix was done in 2.3-develop: 3a1eab9
Could you check it?

[ghost]

Hi @ihor-sviziev Seems like this not fixed in 2.3-develop

[ihor-sviziev]

Hi @Tomasz-Silpion ,
I discussed with @engcom-backlog-nazar in Slack and we found that this issue was fixed in 2.2-develop branch, but in 2.3-develop branch it's still there.

Looks like this fix was forward ported, but changes overridden by

magento2/lib/internal/Magento/Framework/Console/Cli.php

Lines 160 to 165 in bce63f1

	$requestParams = $this->serviceManager->get('magento-init-params');
	$appBootstrapKey = Bootstrap::INIT_PARAM_FILESYSTEM_DIR_PATHS;
	if (isset($requestParams[$appBootstrapKey]) && !isset($params[$appBootstrapKey])) {
	$params[$appBootstrapKey] = $requestParams[$appBootstrapKey];
	}

We'll be really happy if you could investigate and fix it.

I'm closing this Pull Request as described issue already fixed in 2.2-develop branch.

Thank you for you contribution!

[xyzianz]

ping, this is still an issue in Magento 2.3.3

[ihor-sviziev]

ping, this is still an issue in Magento 2.3.3

@Hrafnahnef could you report separate issue on that? It will be checked again