Skip to content

[FORWARDPORT 2.3] Remove duplicated case statement #14414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

[FORWARDPORT 2.3] Remove duplicated case statement #14414

merged 1 commit into from
Mar 30, 2018

Conversation

coderimus
Copy link
Contributor

@coderimus coderimus commented Mar 28, 2018 •
edited
Loading

Description

Hello,

This is a forward port of #14388 where some duplicated switch-case constructions removed.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this Mar 28, 2018
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1139 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7ca8055 into magento:2.3-develop Mar 30, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 30, 2018
ENGCOM-1139: [FORWARDPORT 2.3] Remove duplicated case statement #14414
fee1953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Component: Sales Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@coderimus @magento-engcom-team @miguelbalparda