[Forwardport] Add getters to product image builder#14433
Merged
magento-engcom-team merged 1 commit intoMar 30, 2018
Conversation
namlier
changed the title
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13414
Hello,
Description
I have added the attributes getter into the product image builder, class
Magento\Catalog\Block\Product\ImageBuilderin order to get them in a plugin for example. We may want to add some attributes and use$subject->getProduct()to get product's data.Fixed Issues (if relevant)
N/A.
Manual testing scenarios
N/A.
Contribution checklist