magento/magento2#14465 Fix empty changelog tables after MySQL restart.

[swnsma]

Leave at least one record after tebles cleanup.

Description

This pull request is related to the issue #14465.
The idea of the fix - leave at least one record in changelog tables.
So after restart of MySQL, tables will never by empty.

Fixed Issues (if relevant)

1. [Indexes] Product 'version_id' lost last 'auro_increment' value after MySQL restart. #14465: Indexes] Product 'version_id' lost last 'auro_increment' value after MySQL restart.

Manual testing scenarios

The test scenario is well described in the issue.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[sidolov]

Hi @swnsma , please, create PR with the same changes to 2.2-develop branch firstly, after that we can proceed with current. Thanks!

[ihor-sviziev]

Hi @sidolov,
I already created PRs to 2.2-develop #14635 and 2.3-develop #14636 branches

[toddbc]

Note: this is essentially the same as #13577, although I played it safe in case of other callers. That should be closed once this is merged, assuming this will be merged instead (my 2.2 and 2.3 PRs were ignored as well.)

[ihor-sviziev]

@toddbc sorry for not processing your PRs, they seemed to me as fix in not optimal way

[magento-engcom-team]

Hi @swnsma. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

[toddbc]

@ihor-sviziev happy to hear feedback. Probably better to say that on the PR than just radio silence. Multiple people in the community hit this bug in the meantime - it could've been fixed sooner.

Although, I'd argue that a single extra SQL query to validate the parameter for something run once a day is not going to break the bank. Most of my PRs (including recent ones) have been to fix major performance issues, so I definitely care about performance.