Skip to content

Align else statements at app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php #14540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

nuzil
Copy link
Contributor

@nuzil nuzil commented Apr 4, 2018

Description

I aligned "else" statement at app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

Cause Usage of "else" in this case can be avoided

Fixed Issues (if relevant)

No, just code improvements

Manual testing scenarios

No, just code improvements

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@nuzil nuzil changed the title Align else statements. Usage not required Align else statements at app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php Apr 4, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 4, 2018
@magento-engcom-team magento-engcom-team merged commit 31f1663 into magento:2.3-develop Apr 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 5, 2018
…portExport/Model/Import/Product/Type/Configurable.php #14540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants