Skip to content

use "Module_Name::template/path" format instead of using template/path i… #14946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2018

Conversation

Jakhotiya
Copy link
Contributor

…n Block class to ensure extensibility of the class. not doing so causes invalid template errors after extending the block class via preference

Description

Often third party modules override core block classes. If the source block classes reference a template without specifying module name like "Vendor_Module::template_path" then block render fails with "nvalid template file: " error.

Manual testing scenarios

  1. Overide the \Magento\Review\Block\Product\ReviewRenderer Block in your custom module via di preference. Leave your custom class empty.
  2. Product details should work.

Contribution checklist

  • [ x] Pull request has a meaningful description of its purpose
  • [ x] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…n Block class to ensure extensibility of the class. not doing so causes invalid template errors after extending the block class via preference
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 2, 2018

CLA assistant check
All committers have signed the CLA.

@larsroettig larsroettig self-requested a review May 2, 2018 19:43
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-1434 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Jakhotiya thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@larsroettig
Copy link
Member

Hi, @Jakhotiya, thank you for collaboration.

@magento-engcom-team magento-engcom-team merged commit 70703da into magento:2.2-develop May 7, 2018
magento-engcom-team pushed a commit that referenced this pull request May 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Jakhotiya. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants