Skip to content

chore: upgrade Node.js to 8 #15018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from May 7, 2018
Merged

chore: upgrade Node.js to 8 #15018

merged 1 commit into from May 7, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 5, 2018

Description

Node.s 6 a bit old (4 is EOL since last month), 8 is the current LTS release and 10 is the current stable. So we should check the current Node.js LTS release which will also bring a better performance (and also automatic npm 5 with automatic package-lock.json generation).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

@DanielRuf , thank you for collaboration. Good job)

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@DanielRuf DanielRuf deleted the chore/upgrade-nodejs-to-8 branch May 7, 2018 06:33
@DanielRuf
Copy link
Contributor Author

I guess we should also do this in the 2.3-develop branch. Should / can I collect my PRs that I have to port to 2.3-develop in a separate issue as reminder for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants