[TASK] Solve issue #14966 - Disabling product does not remove it from…

[lewisvoncken]

… the flat index

Description

When you disable a product it should be removed from the flat table

Fixed Issues (if relevant)

1. Disabling product does not remove it from the flat index #14966: Disabling product does not remove it from the flat index

Manual testing scenarios

1. Install Magento 2.2.3 together with the sample data set.
2. Make sure cron is run every minute (bin/magento cron:run).
3. Make sure the config setting Use Flat Catalog Product is set to Yes.
4. Make sure the flat index is up-to-date: bin/magento index:reindex catalog_product_flat.
5. Choose an enabled product in the Magento admin backend. Say its ID is X.
6. Make sure that there exists an entry in table catalog_product_flat_1 with entity_id = X. If not, you've done something wrong.
7. Now, in the Magento admin backend, disable the product.
8. Wait a few minutes.
9. Check whether the table catalog_product_flat_1 still contains an entry with entity_id = X.

Expected result

1. The table catalog_product_flat_1 should contain no entry with entity_id = X.

Actual result

1. The table catalog_product_flat_1 contains an entry with entity_id = X.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[VladimirZaets]

@lewisvoncken, due to Magento backward-compatible guide we can't add a new required dependency to the constructor.

[lewisvoncken]

@VladimirZaets thanks for the feedback. The dependency incorrect and I have just removed it.

[ishakhsuvarov]

Hi @lewisvoncken
I am going to run some more tests with internal CICD, including performance and functional, and proceed with processing, if it's all good.
I've noticed you have created a branch in the magento/magento2 for this Pull Request. It is not really encouraged, so please use your own fork in the future

Thanks

[lewisvoncken]

@ishakhsuvarov

next time I will use the fork. Thanks for looking into this pull request!

[magento-engcom-team]

Hi @lewisvoncken. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.