Skip to content

[2.3-develop] [ForwardPort] Port of #12285 The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery #15021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2018
Merged

[2.3-develop] [ForwardPort] Port of #12285 The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery #15021

merged 5 commits into from
May 9, 2018

Conversation

gwharton
Copy link
Contributor

@gwharton gwharton commented May 5, 2018 •
edited
Loading

Description

Change the type of config variables of values "true" and "false" to type boolean, instead of string.

Fixed Issues (if relevant)

  1. The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery #12285: The option false for mobile device don't work in product view page gallery

Whilst the original bug was not reported against 2.3, this needs applying to be consistent across releases. We cant have 2.2 changing from strings to booleans, and 2.3 remaining as strings.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

[2.3-develop] [ForwardPort] Port of #12285 The option <var name="allo…
435b165 
…wfullscreen">false</var> for mobile device don't work in product view page gallery

Change the type of config variables of values "true" and "false" to type boolean, instead of string.
@gwharton gwharton mentioned this pull request May 5, 2018
Merged
4 tasks
@gwharton gwharton changed the title [2.3-develop] [ForwardPort] Port of #12285 The option <var name="allo… [2.3-develop] [ForwardPort] Port of #12285 The option <var name="allowfullscreen">false</var> for mobile device don't work in product view page gallery May 5, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 5, 2018
@VladimirZaets
Copy link
Contributor

Hi, @gwharton , I took your PR into processing, thank you for collaboration.

@magento-engcom-team magento-engcom-team mentioned this pull request May 9, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 2701a4f into magento:2.3-develop May 9, 2018
magento-engcom-team pushed a commit that referenced this pull request May 9, 2018
@VladimirZaets
ENGCOM-1456: [2.3-develop] [ForwardPort] Port of #12285 The option <v…
521518f 
…ar name="allowfullscreen">false</var> for mobile device don't work in product view page gallery #15021
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@gwharton gwharton deleted the 2.3-develop-12285 branch May 9, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@gwharton @VladimirZaets @magento-engcom-team