Skip to content

Fix unnecessary recalculation of product list pricing #15089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Fix unnecessary recalculation of product list pricing #15089

merged 1 commit into from
May 22, 2018

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented May 9, 2018 •
edited
Loading

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns #14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@JeroenVanLeusden JeroenVanLeusden added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 9, 2018
@miguelbalparda miguelbalparda self-assigned this May 9, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1551 has been created to process this Pull Request

@JeroenVanLeusden JeroenVanLeusden mentioned this pull request May 14, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team mentioned this pull request May 22, 2018
Closed
magento-team pushed a commit that referenced this pull request May 22, 2018
ENGCOM-1551: Fix unnecessary recalculation of product list pricing #1…
2401aa5 
…5089
@magento-engcom-team magento-engcom-team merged commit c5536d3 into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 23, 2018
Closed
Closed
Merged
@JeroenVanLeusden JeroenVanLeusden deleted the patch-2 branch July 9, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@JeroenVanLeusden @magento-engcom-team @miguelbalparda