Add missing false-check to the ConfiguredRegularPrice price-model

[tkotosz]

Description

parent::getValue() can return false while $this->configuredOptions->getItemOptionsValue only accepts float. So if the parent method returns false then it fails with the following error:

NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Magento\Catalog\Pricing\Price\ConfiguredOptions::getItemOptionsValue() must be of the type float, boolean given, called in /app/vendor/magento/module-catalog/Pricing/Price/ConfiguredRegularPrice.php on line 74 and defined in /app/vendor/magento/module-catalog/Pricing/Price/ConfiguredOptions.php:24

[VladimirZaets]

Hi @tkotosz, thank you for collaboration.
You can modify condition in return statement.
It will look like:

return $this->item && $basePrice !== false
             ? $basePrice + $this->configuredOptions->getItemOptionsValue($basePrice, $this->item)
             : $basePrice;

[VladimirZaets]

@tkotosz thanks for the fast update.

[magento-engcom-team]

Hi @tkotosz. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.