Skip to content

Fix typo in Image::open exception message #15269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2018
Merged

Fix typo in Image::open exception message #15269

merged 1 commit into from
May 20, 2018

Conversation

t-richards
Copy link
Contributor

@t-richards t-richards commented May 17, 2018

Description

Fixes a typo in the \Magento\Framework\Image::open exception message.

Previous message:

File {file} does not exists.

Corrected message:

File {file} does not exist.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Given that...
  • There exists a page where an image is opened,
  • but the actual image file does not exist,
  • and the exception is not silently caught and ignored,
  1. Expect to receive a properly-spelled exception message.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this May 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1582 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@t-richards thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@DanielRuf DanielRuf self-requested a review May 17, 2018 21:11
@magento-engcom-team
Copy link
Contributor

Hi @t-richards. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@t-richards
Copy link
Contributor Author

@magento-engcom-team It does not appear that changes from this Pull Request made it into the 2.2.5 release.

https://github.com/magento/magento2/blob/2.2.5/lib/internal/Magento/Framework/Image.php#L52

@dmanners
Copy link
Contributor

Hi @t-richards it looks like there was a miss-configuration with our bot and it had the wrong cut of date for changes to make it into the 2.2.5 release. Sorry for any inconvenience this has caused but your changes will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants