Skip to content

[fix] typo in method name _exportAddress[s]es #15275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2018
Merged

[fix] typo in method name _exportAddress[s]es #15275

merged 2 commits into from
May 22, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 17, 2018 •
edited
Loading

Description

Method name \Magento\Paypal\Model\Api\Nvp::_exportAddressses contained typo
Renamed it to _exportAddresses.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mhauri mhauri changed the title [fix] typo in method name from Nvp class [fix] typo in method name _exportAddress[s]es May 17, 2018
@miguelbalparda miguelbalparda self-assigned this May 17, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1581 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@mhauri thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

miguelbalparda
miguelbalparda requested changes May 17, 2018
View reviewed changes
Copy link
Contributor

@miguelbalparda miguelbalparda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html

@DanielRuf DanielRuf self-requested a review May 17, 2018 21:12
@mhauri
Copy link
Author

mhauri commented May 18, 2018

@miguelbalparda I've added the deprecated notice in commit: 1a0c8e5

@miguelbalparda
Copy link
Contributor

Hi @DanielRuf, I saw you approved quite a few PRs. We try to reserve this for maintainers, in the future feel free to add +1 or emoji answers instead of that. Thanks!

@DanielRuf
Copy link
Contributor

in the future feel free to add +1 or emoji answers instead of that. Thanks!

Ok, understood. Did not know this. Sorry.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1581 has been created to process this Pull Request

magento-team pushed a commit that referenced this pull request May 22, 2018
ENGCOM-1581: [fix] typo in method name _exportAddress[s]es #15275
2821a28
@magento-engcom-team magento-engcom-team merged commit 1a0c8e5 into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@osrecio osrecio mentioned this pull request May 29, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@mhauri @magento-engcom-team @miguelbalparda @DanielRuf @orlangur