Skip to content

Fix typos in variable names #15294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ public function __inject(
/**
* Run Lock user when creating new integration test.
*
* @param Integration $initintegration
* @param Integration $initIntegration
* @param Integration $integration
* @param int $attempts
* @param User $customAdmin
* @param string $configData
* @return void
*/
public function test(
Integration $initintegration,
Integration $initIntegration,
Integration $integration,
$attempts,
User $customAdmin,
Expand All @@ -106,15 +106,15 @@ public function test(
['configData' => $this->configData]
)->run();
$customAdmin->persist();
$initintegration->persist();
$initIntegration->persist();

// login to backend with new user
$this->adminAuthLogin->open();
$this->adminAuthLogin->getLoginBlock()->fill($customAdmin);
$this->adminAuthLogin->getLoginBlock()->submit();

// Steps
$filter = ['name' => $initintegration->getName()];
$filter = ['name' => $initIntegration->getName()];
$this->integrationIndexPage->open();
$this->integrationIndexPage->getIntegrationGrid()->searchAndOpen($filter);
for ($i = 0; $i < $attempts; $i++) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ public function processAssert(CheckoutOnepage $checkoutOnepage, $shippingMethod,
'Shipping rate has not been changed.'
);
}
$shippingAvaialability = $isShippingAvailable ? 'avaiable' : 'unavailable';
$shippingAvailability = $isShippingAvailable ? 'avaiable' : 'unavailable';
\PHPUnit_Framework_Assert::assertEquals(
$isShippingAvailable,
$checkoutOnepage->getShippingMethodBlock()->isShippingMethodAvaiable($shippingMethod),
"Shipping rates for {$shippingMethod['shipping_service']} should be $shippingAvaialability."
"Shipping rates for {$shippingMethod['shipping_service']} should be $shippingAvailability."
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,48 @@
* See COPYING.txt for license details.
*/
$om = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(
\Magento\Framework\Notification\MessageInterface::SEVERITY_CRITICAL
)->setTitle(
'Unread Critical 1'
)->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(\Magento\Framework\Notification\MessageInterface::SEVERITY_MAJOR)
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(\Magento\Framework\Notification\MessageInterface::SEVERITY_MAJOR)
->setTitle('Unread Major 1')
->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(
\Magento\Framework\Notification\MessageInterface::SEVERITY_CRITICAL
)->setTitle(
'Unread Critical 2'
)->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(
\Magento\Framework\Notification\MessageInterface::SEVERITY_CRITICAL
)->setTitle(
'Unread Critical 3'
)->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(
\Magento\Framework\Notification\MessageInterface::SEVERITY_CRITICAL
)->setTitle(
'Read Critical 1'
)->setIsRead(
1
)->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(\Magento\Framework\Notification\MessageInterface::SEVERITY_MAJOR)
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(\Magento\Framework\Notification\MessageInterface::SEVERITY_MAJOR)
->setTitle('Unread Major 2')
->save();

$mesasge = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$mesasge->setSeverity(
$message = $om->create(\Magento\AdminNotification\Model\Inbox::class);
$message->setSeverity(
\Magento\Framework\Notification\MessageInterface::SEVERITY_CRITICAL
)->setTitle(
'Removed Critical 1'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ public function testSetBaseFilePlaceholder()
$model = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
\Magento\Catalog\Model\Product\Image::class
);
/** @var \Magento\Catalog\Model\View\Asset\Placeholder $defualtPlaceholder */
$defualtPlaceholder = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
/** @var \Magento\Catalog\Model\View\Asset\Placeholder $defaultPlaceholder */
$defaultPlaceholder = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
->create(\Magento\Catalog\Model\View\Asset\Placeholder::class,
['type' => 'image']
);

$model->setDestinationSubdir('image');
$model->setBaseFile('');
$this->assertEquals($defualtPlaceholder->getSourceFile(), $model->getBaseFile());
$this->assertEquals($defaultPlaceholder->getSourceFile(), $model->getBaseFile());
return $model;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,14 @@ public function testGetList()
$this->assertEquals(0, $this->model->getVersion());
//the same that a table is empty
$changelogName = $this->resource->getTableName($this->model->getName());
$testChengelogData = [
$testChangelogData = [
['version_id' => 1, 'entity_id' => 1],
['version_id' => 2, 'entity_id' => 1],
['version_id' => 3, 'entity_id' => 2],
['version_id' => 4, 'entity_id' => 3],
['version_id' => 5, 'entity_id' => 1],
];
foreach ($testChengelogData as $data) {
foreach ($testChangelogData as $data) {
$this->connection->insert($changelogName, $data);
}
$this->assertEquals(5, $this->model->getVersion());
Expand Down