Skip to content

Fix typo in test method's name and test result #15297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmytro-ch
Copy link
Contributor

Note: Already fixed in 2.3-develop (as part of #13300), no forwardport needed.

Description

Fix typo in test method's name and in a test result

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 18, 2018
@dmytro-ch dmytro-ch requested a review from rogyar May 18, 2018 05:29
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 18, 2018
@rogyar
Copy link
Contributor

rogyar commented May 18, 2018

Hello @dmytro-ch. Thank you for your collaboration. To preserve backward compatibility, it's prohibited to remove existing public or protected methods.

Check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#php for the details.

You can mark the old method as @deprecated, create a new one and proxy invoking of the new method in the old one.

dmytro-ch added 2 commits June 2, 2018 22:11
…result-value

# Conflicts:
#	dev/tests/functional/tests/app/Magento/Shipping/Test/Constraint/AssertCityBasedShippingRateChanged.php
@dmytro-ch
Copy link
Contributor Author

@rogyar thank you. I've updated the pull request.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 7, 2018
@magento-engcom-team magento-engcom-team merged commit 73afa84 into magento:2.2-develop Jun 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants