Unable to render page when 'meta title' page config param is set #issue-2956

[rainashikha]

Description

Fixed. Added a check to to see if returned content is object or not. As objects will never be converted to string and will throw error for str_replace at line 125

Fixed Issues (if relevant)

1. Unable to render page when 'meta title' page config param is set #2956: Unable to render page when 'meta title' page config param is set

Manual testing scenarios

1. Use the "Steps to reproduce" in original issue.
2. View the source generated in browser.
3. You will be able to see <meta name="title" content="some meta title"/> in source code.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[VladimirZaets]

Hi, @rainashikha. Thanks for collaboration.
We have the fix this issue in current 2.3-develop
Can you please make the backport from 2.3 to 2.2-develop for code consistency?

Related commit(s):

• 32e2e4de5921ecb7b13722955298e886ec2b2d59
• b11c7e78b24450ec4d3e73534c40ab427e786cdd
• 474e43cfb97617355d6d17ec7eb7639789319a7d

[gelanivishal]

@rainashikha Please sign our Contributor License Agreement before we can accept your contribution.

[sidolov]

@rainashikha , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

[rainashikha]

i had got this message..

We have the fix this issue in current 2.3-develop
Can you please make the backport from 2.3 to 2.2-develop for code consistency?

so please let me know what is required from my end? are u merging this pull request? is anything pending?