Skip to content

15210-Fixed product tier pricing pagination issue in admin #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 7 commits into from
May 25, 2018
Merged

15210-Fixed product tier pricing pagination issue in admin #15360

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cad44a3
15210-Fixed product tier pricing pagination issue in admin
saravananvelu May 19, 2018
560aa38
Fixed coding related issue
gelanivishal May 20, 2018
8a8ed66
Removed Illegal trailing whitespace.
gelanivishal May 22, 2018
ba6bf77
Removed newly added comments
saravananvelu May 23, 2018
6de6006
Inherited the parent method to fix pagination issue
saravananvelu May 23, 2018
ec3eb1a
Fixed product tier pricing pagination issue in admin
saravananvelu May 23, 2018
75960ce
15210-Fixed product tier pricing pagination
VladimirZaets May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions app/code/Magento/Catalog/view/adminhtml/web/js/components/dynamic-rows-tier-price.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,33 @@ define([
});

this.labels(labels);
},

/**
* Change page
*
* @param {Number} page - current page
*/
changePage: function (page) {
this.clear();

if (page === 1 && !this.recordData().length) {
Copy link
Contributor

@VladimirZaets VladimirZaets May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saravananvelu. Thanks for the collaboration.
This issue reproduced in all places where dynamic-rows component is used, so will be great if you fix this issue in the more general way, in the parent class.

Also, you can call the method from the parent class (this._super()) instead of copy-paste it

Copy link
Contributor Author

@saravananvelu saravananvelu May 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the code in parent class and removed the same from child class

return false;
}

if (~~page > this.pages()) {
this.currentPage(this.pages());

return false;
} else if (~~page < 1) {
this.currentPage(1);

return false;
}

this.initChildren();

return true;
}
});
});