Skip to content

[Backport] Remove non-existing argument #15394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2018
Merged

[Backport] Remove non-existing argument #15394

merged 1 commit into from
May 21, 2018

Conversation

dmytro-ch
Copy link
Contributor

Original PR: #15249

Description

Removed non-existing argument from constructor method's PHPDoc.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.1 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 20, 2018
@dmytro-ch dmytro-ch requested a review from rogyar May 20, 2018 20:06
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 21, 2018
@sidolov
Copy link
Contributor

sidolov commented May 21, 2018

Hi @dmytro-ch , please, next time try to combine all typos PRs to one

@magento-engcom-team magento-engcom-team merged commit 3c89d45 into magento:2.1-develop May 21, 2018
magento-engcom-team pushed a commit that referenced this pull request May 21, 2018
ENGCOM-1612: [Backport] Remove non-existing argument #15394
a03e205
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ch @sidolov @magento-engcom-team @rogyar