Skip to content

typo correction #15431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2018
Merged

typo correction #15431

merged 1 commit into from
May 23, 2018

Conversation

AnshuMishra17
Copy link
Contributor

Description
Corrected spelling mistake.
Changed requere to require in comments for public function addTaxPercents()

@orlangur orlangur self-assigned this May 22, 2018
orlangur
orlangur approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/AnshuMishra17/magento2/blob/b2d43e17d7be5afff4241b25c71dcbdc17182664/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php#L1583

Not sure what these sentences actually mean but approved :)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1647 has been created to process this Pull Request

magento-team pushed a commit that referenced this pull request May 23, 2018
ENGCOM-1647: typo correction #15431
4ac5828
@magento-engcom-team magento-engcom-team merged commit b2d43e1 into magento:2.2-develop May 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 23, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@AnshuMishra17 @magento-engcom-team @orlangur