Skip to content

Fix HTML syntax in report.phtml error template #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018

Conversation

abcpremium
Copy link

@abcpremium abcpremium commented May 23, 2018

Added missing quotes to the div tags with class control.

Description

Added missing quotes to the class attribute of div tags in the default reporting template file in pub/errors/default/report.phtml

Fixed Issues (if relevant)

Manual testing scenarios

  1. Open in any editor with syntax highlighting, it shouldn't show any more syntax warnings.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Added missing quotes to the div tags with class "control".
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 23, 2018

CLA assistant check
All committers have signed the CLA.

@avoelkl avoelkl self-assigned this May 23, 2018
@avoelkl
Copy link
Contributor

avoelkl commented May 23, 2018

Hi @abcpremium! Thanks for the PR! I can see the quotes are missing in the 2.3-develop branch as well. Once this PR is done it would be great to apply the same in the 2.3 branch (if you like).

@magento-engcom-team
Copy link
Contributor

Hi @avoelkl, thank you for the review.
ENGCOM-1654 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@abcpremium thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@abcpremium
Copy link
Author

Hey @avoelkl, thanks for accepting the PR. However, this is my first PR ever, so when you say I should do this for 2.3-develop also, do you mean the exact same procedure as this one? Or can I "modify" this PR to include both 2.2-develop and 2.3-develop? Sorry for this stupid question shame on me

@avoelkl
Copy link
Contributor

avoelkl commented May 23, 2018

Hi @abcpremium,
No shame, there's a first time for everything!
Actually you would need to apply the same changes on the 2.3 branch and create a new pull request. Please do not modify this pull request. I hope this helps :)

@avoelkl
Copy link
Contributor

avoelkl commented May 23, 2018

Actually there is a tool for porting changes here: https://github.com/magento/magento2/wiki/Simple-way-to-port-your-solutions-automatically. I haven't tried it myself but if you want to give it a try I am sure we can find someone to help with this.

@magento-engcom-team magento-engcom-team merged commit 07f96a5 into magento:2.2-develop May 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @abcpremium. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@abcpremium
Copy link
Author

@avoelkl Alright I used the tool to port my changes to 2.3-develop. Really easy to use it, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants