Skip to content

[Resolved : UI Component listing action column outside of screen when… #15459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

The dropdown menu should be positioned under the link

Description

Fixed Issues (if relevant)

  1. UI Component listing action column outside of screen when too many columns #14153: Issue title UI Component listing action column outside of screen when too many columns

Manual testing scenarios

  1. Edit cms_page_listing.xml
       <column name="text1">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text2">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text3">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text4">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text5">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text6">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text7">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text8">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text9">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text10">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text11">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text12">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text13">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
  1. Add the following snippet to the columns tag:
  2. Clear cache and empty ui_bookmark table
  3. Go to CMS page listing
  4. Resize screen to 1200px wide
  5. Scroll to the right to the actions column
  6. Click on it

Actual Result

image

Expected Result

expected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vijay-wagento
Copy link

@dmanners Could you please check what cause failed travis?
Thanks,

@dmanners
Copy link
Contributor

Hi @hitesh-wagento and @vijay-wagento I have restarted the test as it looked like it had stopped for some reason. If it fails again just drop me a message and I can take a look for you.

@vijay-wagento
Copy link

@dmanners Thanks, seems like all good now.

@osrecio osrecio self-assigned this May 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 25, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels May 25, 2018
@magento-engcom-team
Copy link
Contributor

@hitesh-wagento thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants