Skip to content

Missing PHPDoc comment #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2018
Merged

Missing PHPDoc comment #15498

merged 4 commits into from
Jun 1, 2018

Conversation

lfluvisotto
Copy link
Contributor

Missing PHPDoc comment

Description

Quality assurance improvements, code quality.

Fixed Issues (if relevant)

N/A

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 25, 2018
@magento-engcom-team
Copy link
Contributor

@lfluvisotto thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

sidolov
sidolov requested changes May 29, 2018
View reviewed changes
...del/Resolver/Products/DataProvider/Product/CollectionProcessor/ExtensibleEntityProcessor.php Outdated
Collection $collection,
SearchCriteriaInterface $searchCriteria,
array $attributeNames
Collection $collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation not compatible with implemented interface \Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Product\CollectionProcessorInterface
Please, revert this changes

@lfluvisotto lfluvisotto force-pushed the 2.3-develop-missing-phpdoc-comment branch from 68a17eb to 2a20abd Compare May 29, 2018 08:40
@lfluvisotto
Copy link
Contributor Author

@sidolov I think the issue is the code that it was already there and not the phpdoc I put, so let's see the travis-ci and codacy results.

@lfluvisotto
Copy link
Contributor Author

@sidolov done!

Codacy/PR Quality Review — Up to standards. A positive pull request.

continuous-integration/travis-ci/pr — The Travis CI build passed

@magento-engcom-team magento-engcom-team merged commit d6aabc3 into magento:2.3-develop Jun 1, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 1, 2018
ENGCOM-1667: Missing PHPDoc comment #15498
2543ff4
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@nmalevanec nmalevanec mentioned this pull request Aug 23, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov requested changes

Assignees

@rogyar rogyar

Labels
Component: Framework/Exception Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Component: NewRelicReporting Component: Sales Component: Setup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lfluvisotto @magento-engcom-team @sidolov @rogyar