Skip to content

Issue 15469: Javascript error dropdowns.js #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2018

Conversation

brian-labelle
Copy link
Contributor

@brian-labelle brian-labelle commented May 24, 2018

Fixes Javascript error in dropdowns.js by properly initializing the el variable. options.autoclose can now be set to false

Description

Initialize the el variable outside of the condition checking for options.autoclose === true

Fixed Issues

  1. lib/web/mage/dropdowns.js fails when autoclose is set to true #15469: lib/web/mage/dropdowns.js fails when autoclose is set to true

Manual testing scenarios

  1. In a javascript file, call dropdown on an element with autoclose: false
$(this.selector).dropdown({
    autoclose: false
});
  1. Open and close the dropdown, verifying no javascript errors occur in the console

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixes Javascript error in dropdowns.js by properly initializing the el variable. options.autoclose can now be set to false
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@brian-labelle thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @brian-labelle. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants