Fix method name (typo) #15514
Merged
Fix method name (typo) #15514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanners
suggested changes
May 25, 2018
| @@ -319,9 +319,18 @@ public function getQuote() | |||
| } | |||
|
|
|||
| /** | |||
| * @return mixed | |||
There was a problem hiding this comment.
I think we might want to keep the return here
|
Hi @dmanners, I updated the PR and re-added the return in the doc. |
|
Thanks @avoelkl I will process this now. |
dmanners
approved these changes
May 28, 2018
|
Hi @dmanners, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 1, 2018
|
Hi @avoelkl. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
ihor-sviziev
reviewed
Jun 1, 2018
| @@ -5,7 +5,7 @@ | |||
| */ | |||
|
|
|||
| /** | |||
| * Multishipping checkout base abstract block | |||
| * Mustishipping checkout base abstract block | |||
There was a problem hiding this comment.
Multishipping was correct
| @@ -9,7 +9,7 @@ | |||
| use Magento\Quote\Model\Quote\Address; | |||
|
|
|||
| /** | |||
| * Multishipping checkout shipping | |||
| * Mustishipping checkout shipping | |||
There was a problem hiding this comment.
Multishipping was correct
| @@ -72,7 +72,7 @@ public function getAdminPasswordLifetime() | |||
| } | |||
|
|
|||
| /** | |||
| * Get admin maximum security failures from config | |||
| * Get admin maxiumum security failures from config | |||
This was referenced Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates a current method with a typo and introduces the new method with correct spelling
Fixed Issues (if relevant)
none
Contribution checklist